Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bazel WORKSPACE setup. #8509

Merged
merged 1 commit into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
buildifier: latest
matrix:
bazel:
- 6.x
- 7.x
- 8.x
tasks:
Expand Down
1 change: 0 additions & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ filegroup(
".npmrc",
"BUILD.bazel",
"MODULE.bazel",
"WORKSPACE",
"build_defs.bzl",
"package.json",
"pnpm-lock.yaml",
Expand Down
189 changes: 0 additions & 189 deletions WORKSPACE

This file was deleted.

3 changes: 0 additions & 3 deletions WORKSPACE.bzlmod

This file was deleted.

10 changes: 2 additions & 8 deletions build_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,21 @@ Rules for building C++ flatbuffers with Bazel.

load("@rules_cc//cc:defs.bzl", "cc_library")

def repo_name(label):
if hasattr(label, "repo_name"): # Added in Bazel 7.1
return label.repo_name
else:
return "com_github_google_flatbuffers"

TRUE_FLATC_PATH = Label("//:flatc")

DEFAULT_INCLUDE_PATHS = [
"./",
"$(GENDIR)",
"$(BINDIR)",
"$(execpath %s).runfiles/%s" % (TRUE_FLATC_PATH, repo_name(TRUE_FLATC_PATH)),
"$(execpath %s).runfiles/%s" % (TRUE_FLATC_PATH, TRUE_FLATC_PATH.repo_name),
]

def default_include_paths(flatc_path):
return [
"./",
"$(GENDIR)",
"$(BINDIR)",
"$(execpath %s).runfiles/%s" % (flatc_path, repo_name(flatc_path)),
"$(execpath %s).runfiles/%s" % (flatc_path, flatc_path.repo_name),
]

DEFAULT_FLATC_ARGS = [
Expand Down
5 changes: 0 additions & 5 deletions tests/bazel_repository_test_dir/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
This directory is not intended to be used independently of the flatbuffers
repository. Instead, this whole directory serves as a unit test for the
C++ integration in the flatbuffers repo.

Run this test from the top-level of the flatbuffers repo.
```console
$ bazel test //tests:bazel_repository_test
```
6 changes: 0 additions & 6 deletions tests/bazel_repository_test_dir/WORKSPACE

This file was deleted.

3 changes: 0 additions & 3 deletions tests/bazel_repository_test_dir/WORKSPACE.bzlmod

This file was deleted.

82 changes: 0 additions & 82 deletions tests/ts/bazel_repository_test_dir/WORKSPACE

This file was deleted.

3 changes: 0 additions & 3 deletions tests/ts/bazel_repository_test_dir/WORKSPACE.bzlmod

This file was deleted.

1 change: 0 additions & 1 deletion ts/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ filegroup(
"BUILD.bazel",
"compile_flat_file.sh",
"pnpm-lock.yaml",
"repositories.bzl",
] + glob([
"*.ts",
]),
Expand Down
22 changes: 0 additions & 22 deletions ts/repositories.bzl

This file was deleted.

Loading