Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] Add NNX WeightNorm. #4568

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[nnx] Add NNX WeightNorm. #4568

wants to merge 5 commits into from

Conversation

nilq
Copy link

@nilq nilq commented Feb 24, 2025

What does this PR do?

This PR addresses #4426 by implementing an NNX WeightNorm class. This brings the requested normalization class to the NNX library – implemented to be consistent with the corresponding module in Linen.

Checklist

Copy link

google-cla bot commented Feb 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.


if self.variable_filter:
for variable_name in self.variable_filter:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the same Filter supported by nnx.filterlib which are a bit more general and used thought the library.

@cgarciae
Copy link
Collaborator

cgarciae commented Feb 27, 2025

To resolve the pytest issues you will have to add some deprecation warning to the list here:

flax/pyproject.toml

Lines 186 to 188 in 6af8fcb

# DeprecationWarning: numpy.core is deprecated
"ignore:.*numpy.core is deprecated.*:DeprecationWarning",
]

If this is not from your PR we can fix it in main first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants