Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kakao Small Sans to Google Fonts #9015

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

on-the-heath
Copy link

This PR adds the Kakao Small Sans font with the required metadata files.

  • Family name: Kakao Small Sans
  • License: Open Font License (OFL-1.1)
  • Files: METADATA.pb, OFL.txt, TTF font files

Copy link

google-cla bot commented Jan 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@on-the-heath
Copy link
Author

Hello, I have already signed the CLA for my previous PR (#9014) where I submitted Kakao Big Sans.

This PR (#9015) is part of the same project, adding Kakao Small Sans to Google Fonts. Since both submissions come from the same contributor and organization, could you please verify the CLA status for this PR as well?

Thank you!

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 29, 2025

Thank you very much for the submission. It looks very nice!

I'm curious. Could you please answer the following questions:

  • Is this font an original creation?
  • Is the Latin original?

@on-the-heath
Copy link
Author

Thank you for reviewing this submission. I'm very happy to contribute to Google Fonts.

Kakao Small Sans (as well as Kakao Big Sans) is an original typeface, with the Korean font designed by Fontrix Inc. and the Latin font designed by Bon Min.

This typeface was created as part of a project by Kakao Corp., and the copyright is fully owned by Kakao.

If you have any further questions, please feel free to ask.

@on-the-heath
Copy link
Author

I reviewed the issue after seeing the failure in the "Run ftxvalidator on new/changed fonts" check.
It appears that the error was caused by an incorrect font filename in the METADATA.pb file.

Would it be okay for me to update the file and push the corrected version to this PR? Please let me know how to proceed.

Thank you in advance.

@on-the-heath
Copy link
Author

It looks like the "hdiutil attach font_tools.dmg" step failed due to a missing file in the QA environment.
Could you confirm if this issue is related to the build system, or if there is something I need to change on my end?
Please let me know how to proceed.

Thanks,

Changed the font labeled 'Weight: 300' to Kakao Small Sans Light'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants