Pochaevsk: Version 1.210; ttfautohint (v1.8.4.7-5d5b) added

[yanone]

Taken from the upstream repo https://github.com/slavonic/pochaevsk at commit slavonic/Pochaevsk@4238da8.

Resolves #8727

PR Checklist:

• primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
• subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
• Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
• Diffenator2 regression checks for revisions on all projects that are currently in production

[yanone]

Author just completed the GF_Cyrillic_Historical glyphset so that the font can show up for "Church Slavic" language setting in the GF UI.

[github-actions]

FontBakery report

fontbakery version: 0.13.1

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] Pochaevsk-Regular.ttf

💥 ERROR Check base characters have non-zero advance width. base_has_width

• 💥 ERROR

  Failed with AttributeError: 'CheckRunContext' object has no attribute 'get'

  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 222, in _run_check
    subresults = list(subresults)
  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/checks/base_has_width.py", line 46, in check_base_has_width
    problems = bullet_list(context, problems)
  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/utils.py", line 155, in bullet_list
    return f"{indentation}{bullet} " + pretty_print_list(
  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/utils.py", line 140, in pretty_print_list
    if config.get("full_lists"):

[code: failed-check]

All other checks

[26] Pochaevsk-Regular.ttf

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. googlefonts/metadata/consistent_repo_urls

• 🔥 FAIL

  Repository URL is https://github.com/slavonic/pochaevsk

But: OFL text has 'https://github.com/slavonic/Pochaevsk'

[code: mismatch]

🔥 FAIL Check Google Fonts glyph coverage. googlefonts/glyph_coverage

• 🔥 FAIL

  Missing required codepoints:

- 0x2122 (TRADE MARK SIGN)

[code: missing-codepoints]

🔥 FAIL Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts. googlefonts/vertical_metrics_regressions

• 🔥 FAIL

  Pochaevsk Regular: OS/2 sTypoDescender is -400 when it should be -433

  
  [code: bad-typo-descender]

• 🔥 FAIL

  Pochaevsk Regular: hhea Descender is -400 when it should be -433

  
  [code: bad-hhea-descender]

⚠️ WARN Check mark characters are in GDEF mark glyph class. opentype/gdef_mark_chars

• ⚠️ WARN

  The following mark characters could be in the GDEF mark glyph class:
  uni0360 (U+0360), uni20DD (U+20DD) and uniA66F (U+A66F)

  
  [code: mark-chars]

⚠️ WARN Check glyphs in mark glyph class are non-spacing. opentype/gdef_spacing_marks

• ⚠️ WARN

  The following glyphs seem to be spacing (because they have width > 0 on the hmtx table) so they may be in the GDEF mark glyph class by mistake, or they should have zero width instead:
  acutecomb (U+0301), gravecomb (U+0300), uni0307 (U+0307), uni0308 (U+0308), uni030B (U+030B), uni030F (U+030F), uni0311 (U+0311), uni0483 (U+0483), uni0484 (U+0484), uni0485 (U+0485) and 13 more.

Use -F or --full-lists to disable shortening of long lists.

[code: spacing-mark-glyphs]

⚠️ WARN Check if each glyph has the recommended amount of contours. contour_count

• ⚠️ WARN

  This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: .null	Contours detected: 2	Expected: 0


Glyph name: ydieresis	Contours detected: 2	Expected: 3


Glyph name: afii10044	Contours detected: 1	Expected: 2


Glyph name: afii10070	Contours detected: 1	Expected: 2


Glyph name: afii10076	Contours detected: 2	Expected: 1


Glyph name: afii10092	Contours detected: 1	Expected: 2


Glyph name: uni0450	Contours detected: 2	Expected: 3


Glyph name: afii10071	Contours detected: 3	Expected: 4


Glyph name: afii10103	Contours detected: 1	Expected: 2


Glyph name: afii10109	Contours detected: 3	Expected: 2


7 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]

⚠️ WARN Check math signs have the same width. math_signs_width

• ⚠️ WARN

  The most common width is 887 among a set of 4 math glyphs.
  The following math glyphs have a different width, though:

Width = 453: plus

Width = 611: less

Width = 376: equal

Width = 600: greater

Width = 541: logicalnot

Width = 579: divide, multiply, plusminus

Width = 352: minus

[code: width-outliers]

⚠️ WARN Check there are no overlapping path segments overlapping_path_segments

• ⚠️ WARN

  The following glyphs have overlapping path segments:

* uniA66F (U+A66F): B<<144.0,663.0>-<144.0,663.0>-<144.0,663.0>> has the same coordinates as a previous segment.

* uniA66F (U+A66F): L<<144.0,663.0>--<144.0,663.0>> has the same coordinates as a previous segment.

[code: overlapping-path-segments]

⚠️ WARN Does the font contain a soft hyphen? soft_hyphen

• ⚠️ WARN

  This font has a 'Soft Hyphen' character.

  
  [code: softhyphen]

⚠️ WARN Ensure Stylistic Sets have description. stylisticset_description

• ⚠️ WARN

  The stylistic set ss01 lacks a description string on the 'name' table.

  
  [code: missing-description]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images

• ⚠️ WARN

  Family metadata at ofl/pochaevsk does not have an article.

  
  [code: lacks-article]

⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting

• ⚠️ WARN

  The following codepoints supported by the font are not covered by
  any subsets defined in the font's metadata file, and will never
  be served. You can solve this by either manually adding additional
  subset declarations to METADATA.pb, or by editing the glyphset
  definitions.

• U+007F : try adding symbols
• U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
• U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, math, todhri, old-permic, hebrew, tai-le, syriac, duployan, malayalam, coptic, tifinagh
• U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
• U+030F COMBINING DOUBLE GRAVE ACCENT: not included in any glyphset definition
• U+0311 COMBINING INVERTED BREVE: try adding one of: todhri, coptic
• U+033E COMBINING VERTICAL TILDE: not included in any glyphset definition
• U+0360 COMBINING DOUBLE TILDE: not included in any glyphset definition
• U+10FB GEORGIAN PARAGRAPH SEPARATOR: try adding one of: glagolitic, georgian
• U+2000 EN QUAD: try adding symbols2 115 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, latin, menu

[code: unreachable-subsetting]

⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak. googlefonts/description/eof_linebreak

• ⚠️ WARN

  The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.

  
  [code: missing-eof-linebreak]

⚠️ WARN Ensure dotted circle glyph is present and can attach marks. dotted_circle

• ⚠️ WARN

  No dotted circle glyph present

  
  [code: missing-dotted-circle]

⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted

• ⚠️ WARN

  The dot of soft dotted characters used in orthographies must disappear in the following strings: i̋ j̀ j́ j̈ j̑ і́

The dot of soft dotted characters should disappear in other cases, for example: ĭ i̇ ȉ ȋ i̾ i҃ i҄ i҅ i҆ i҇ iⷠ iⷡ iⷢ iⷣ iⷤ iⷥ iⷦ iⷧ iⷨ iⷩ

Your font fully covers the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Sar (Latn, 500,000 speakers), Fur (Latn, 1,230,163 speakers), Heiltsuk (Latn, 300 speakers), Keliko (Latn, 63,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Aghem (Latn, 38,843 speakers), Igbo (Latn, 27,823,640 speakers), Lithuanian (Latn, 2,357,094 speakers), Mfumte (Latn, 79,000 speakers), Southern Kisi (Latn, 360,000 speakers), Zapotec (Latn, 490,000 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Nateni (Latn, 100,000 speakers), Longto (Latn, 5,000 speakers), Lugbara (Latn, 2,200,000 speakers), Northern Tutchone (Latn, 85 speakers), Vute (Latn, 21,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Mango (Latn, 77,000 speakers), Yala (Latn, 200,000 speakers), Gulay (Latn, 250,478 speakers), Basaa (Latn, 332,940 speakers), Southern Tutchone (Latn, 65 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Mundani (Latn, 34,000 speakers), South Central Banda (Latn, 244,000 speakers), Makaa (Latn, 221,000 speakers), Bafut (Latn, 158,146 speakers), Han (Latn, 6 speakers), Ekpeye (Latn, 226,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Western Krahn (Latn, 97,800 speakers), Ikwere (Latn, 717,000 speakers), Dan (Latn, 1,099,244 speakers), Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers), Kaska (Latn, 125 speakers), Koonzime (Latn, 40,000 speakers), Navajo (Latn, 166,319 speakers), Nzakara (Latn, 50,000 speakers), Ebira (Latn, 2,200,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Abua (Latn, 25,000 speakers), Ejagham (Latn, 120,000 speakers), Cicipu (Latn, 44,000 speakers).

[code: soft-dotted]

⚠️ WARN Do outlines contain any jaggy segments? outline_jaggy_segments

• ⚠️ WARN

  The following glyphs have jaggy segments:

* paragraph (U+00B6): L<<41.0,490.0>--<41.0,489.0>>/B<<41.0,489.0>-<43.0,540.0>-<82.0,583.0>> = 2.245742565895049

* u1F312 (U+1F312): B<<468.0,49.0>-<442.0,33.0>-<425.0,33.0>>/B<<425.0,33.0>-<432.0,32.0>-<435.0,32.0>> = 8.13010235415596

* u1F318 (U+1F318): B<<376.5,763.0>-<384.0,766.0>-<393.0,768.0>>/L<<393.0,768.0>--<379.0,768.0>> = 12.528807709151492

* u1F377 (U+1F377): B<<466.5,415.5>-<489.0,424.0>-<507.0,431.0>>/B<<507.0,431.0>-<499.0,430.0>-<487.5,430.0>> = 14.12548915823142

* u1F41F (U+1F41F): B<<516.0,308.0>-<543.0,314.0>-<730.0,332.0>>/B<<730.0,332.0>-<702.0,336.0>-<675.5,337.5>> = 13.62826507913694

* u1F41F (U+1F41F): L<<833.0,445.0>--<914.0,405.0>>/B<<914.0,405.0>-<900.0,416.0>-<900.0,434.0>> = 11.875815566048908

* uni263D (U+263D): B<<114.0,764.0>-<104.0,766.0>-<93.0,767.0>>/B<<93.0,767.0>-<107.0,763.0>-<125.5,749.0>> = 10.750966993188039

* uni263D (U+263D): B<<121.5,28.5>-<110.0,20.0>-<103.0,20.0>>/B<<103.0,20.0>-<110.0,19.0>-<113.0,18.5>> = 8.13010235415596

* uni263E (U+263E): B<<359.5,749.0>-<378.0,763.0>-<392.0,767.0>>/B<<392.0,767.0>-<382.0,766.0>-<372.0,764.0>> = 10.234802763423207

* uni263E (U+263E): B<<372.0,18.5>-<375.0,19.0>-<382.0,20.0>>/B<<382.0,20.0>-<376.0,20.0>-<364.0,28.5>> = 8.13010235415596

[code: found-jaggy-segments]

⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? outline_semi_vertical

• ⚠️ WARN

  The following glyphs have semi-vertical/semi-horizontal lines:

* N (U+004E): L<<556.0,185.0>--<554.0,514.0>>

* Ntilde (U+00D1): L<<556.0,185.0>--<554.0,514.0>>

* T (U+0054): L<<350.0,504.0>--<352.0,124.0>>

* afii10025 (U+0417): L<<90.0,474.0>--<89.0,591.0>>

* afii10043 (U+0429): L<<713.0,607.0>--<712.0,21.0>>

* afii10090 (U+0448): L<<358.0,82.0>--<361.0,451.0>>

* afii10148 (U+0474): L<<211.0,302.0>--<210.0,46.0>>

* bracketleft (U+005B): L<<180.0,-104.0>--<334.0,-103.0>>

* bracketright (U+005D): L<<19.0,-103.0>--<173.0,-104.0>>

* e (U+0065): L<<385.0,256.0>--<119.0,258.0>>

* 18 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags

• ⚠️ WARN

  This font file does not have a 'meta' table.

  
  [code: lacks-meta-table]

⚠️ WARN Checking OS/2 achVendID. googlefonts/vendor_id

• ⚠️ WARN

  OS/2 VendorID value ' ' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx

  
  [code: unknown]

ℹ️ INFO List all superfamily filepaths superfamily/list

• ℹ️ INFO

  ofl/pochaevsk

  
  [code: family-path]

ℹ️ INFO Show hinting filesize impact. hinting_impact

• ℹ️ INFO

  Hinting filesize impact:

	ofl/pochaevsk/Pochaevsk-Regular.ttf
Dehinted Size	115.1kb
Hinted Size	175.9kb
Increase	60.8kb
Change	52.9 %

[code: size-impact]

ℹ️ INFO Font contains all required tables? required_tables

• ℹ️ INFO

  This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url

• ℹ️ INFO

  Please consider adding a family.minisite_url entry.

  
  [code: lacks-minisite-url]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? googlefonts/description/git_url

• ℹ️ INFO

  Found a git repo URL: https://github.com/slavonic/pochaevsk

  
  [code: url-found]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file googlefonts/description/has_article

• ℹ️ INFO

  This font doesn't have an ARTICLE.en_us.html file.

  
  [code: missing-article]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp

• ℹ️ INFO

  These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]

[1] Family checks

ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order

• ℹ️ INFO

  All of the fonts lack a STAT table.

  
  [code: summary]

Summary

💥 ERROR	☠ FATAL	🔥 FAIL	⚠️ WARN	⏩ SKIP	ℹ️ INFO	✅ PASS	🔎 DEBUG
1	0	3	16	54	8	154	0
0%	0%	1%	7%	23%	3%	65%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• PASS
• DEBUG

[yanone]

I don't understand the vertical metrics FAIL. The font currently live on GF has a typo/hhea descender of -400.