Refined registry credential lookup #1966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zregvart
force-pushed
the
pr/credential-lookup
branch
from
0fe1e6a to
cec55a1
Compare
The Container Tools project defines a lookup for authentication from most-specific to least-specific[1]. This change implements that credential lookup. [1] https://github.com/containers/image/blob/main/docs/containers-auth.json.5.md#format
zregvart
force-pushed
the
pr/credential-lookup
branch
from
cec55a1 to
85bb487
Compare
|
@jonjohnsonjr, @imjasonh and @matthewrobertson I'm curious about your thoughts on adopting this change? |
|
This Pull Request is stale because it has been open for 90 days with |
I'm gauging the interest here, do the maintainers wish to incorporate this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Container Tools project defines a lookup for authentication from most-specific to least-specific[1]. This change implements that credential lookup.
[1] https://github.com/containers/image/blob/main/docs/containers-auth.json.5.md#format