Skip to content

Commit

Permalink
Run a test under more environments.
Browse files Browse the repository at this point in the history
It hasn't actually used "mocks" in the sense of "things from a mocking framework" since cl/85631779, which (confusingly) appears to have been the CL that _added_ the "mocks" comment (to replace a previous `@GwtIncompatible` comment about `withFallback`, which wasn't available under GWT until then). (Probably the author had switched away from using a mocking framework during development but then forgotten to remove `@GwtIncompatible` afterward.) It looks like I carried that comment over from `withFallback` to `catchingAsync` in cl/86180055, and then I added a corresponding TODO in cl/116759522. None of that seems to have been necessary.

RELNOTES=n/a
PiperOrigin-RevId: 723210249
  • Loading branch information
cpovirk authored and Google Java Core Libraries committed Feb 4, 2025
1 parent f5fa4ea commit 453549c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1015,9 +1015,6 @@ public void testCatchingAsync_resultCancelledBeforeFallback() throws Exception {
assertFalse(primary.wasInterrupted());
}

@J2ktIncompatible
@GwtIncompatible // mocks
// TODO(cpovirk): eliminate use of mocks
public void testCatchingAsync_resultCancelledAfterFallback() throws Exception {
final SettableFuture<Integer> secondary = SettableFuture.create();
final RuntimeException raisedException = new RuntimeException();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1015,9 +1015,6 @@ public void testCatchingAsync_resultCancelledBeforeFallback() throws Exception {
assertFalse(primary.wasInterrupted());
}

@J2ktIncompatible
@GwtIncompatible // mocks
// TODO(cpovirk): eliminate use of mocks
public void testCatchingAsync_resultCancelledAfterFallback() throws Exception {
final SettableFuture<Integer> secondary = SettableFuture.create();
final RuntimeException raisedException = new RuntimeException();
Expand Down

0 comments on commit 453549c

Please sign in to comment.