Give failureaccess
an Automatic-Module-Name
, and bump its version to 1.0.2 to prepare for a release (which we'll then need to update Guava to use).
#6784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give
failureaccess
anAutomatic-Module-Name
, and bump its version to 1.0.2 to prepare for a release (which we'll then need to update Guava to use).I chose an
Automatic-Module-Name
over an actualmodule-info
, even for this dependency-free artifact, because I can do that without requiring JDK 9+ for builds. Granted, there would be relatively little harm in requiring JDK 9+ forfailureaccess
builds, sincefailureaccess
isn't part of our normal build process. (Guava's build pulls an already released version offailureaccess
.) Still, it's possible that someone is building both Guava andfailureaccess
with JDK 8, so it may be nice not to break that workflow. Plus, I'm not sure that a proper module definition buys us much (relative toAutomatic-Module-Name
) when we have no deps? Still, I am a bit tempted, if only to try to shake out remaining issues thatmodule-info
might cause our users.This CL is progress toward fixing #6776 (or "toward working around a Maven bug," if you prefer).
It's also a tiny bit of progress toward modularizing Guava (#2970), since
failureaccess
is one of its existing unmodularized dependencies.RELNOTES=Added an
Automatic-Module-Name
tofailureaccess
, Guava's one strong runtime dependency.