Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scroll to end screenshot tests #2451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Nov 7, 2024

WHAT

  • Enabled scroll actions in screenshot tests that were previously disabled due to a bug.
  • Updated tests to now properly scroll and capture screenshots.

WHY

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

* Enabled scroll actions in screenshot tests that were previously disabled due to a bug.
* Updated tests to now properly scroll and capture screenshots.
@yschimke yschimke requested a review from garanj November 7, 2024 09:34
@yschimke yschimke closed this Nov 7, 2024
@yschimke yschimke reopened this Nov 7, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, not working currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants