warning instead of error for invalid icc #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some JPEG images in the wild have invalid ICC profiles despite being otherwise valid images. See this issue for an example of a phone that systematically produces such images. As these images can be decoded without issue, simply emitting a warning and ignoring the ICC profile is a better behavior than crashing.
Tested with this sample image and confirmed that it was processed successfully with this change, but failed without it.
Pull Request Checklist
./ci.sh lint
for automatic code formatting.Please review the full contributing guidelines for more details.