Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning instead of error for invalid icc #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mertalev
Copy link

Description

Some JPEG images in the wild have invalid ICC profiles despite being otherwise valid images. See this issue for an example of a phone that systematically produces such images. As these images can be decoded without issue, simply emitting a warning and ignoring the ICC profile is a better behavior than crashing.

Tested with this sample image and confirmed that it was processed successfully with this change, but failed without it.

Pull Request Checklist

  • CLA Signed: Have you signed the Contributor License Agreement (individual or corporate, as appropriate)? Only contributions from signed contributors can be accepted.
  • Authors: Have you considered adding your name to the AUTHORS file?
  • Code Style: Have you ensured your code adheres to the project's coding style guidelines? You can use ./ci.sh lint for automatic code formatting.

Please review the full contributing guidelines for more details.

@mertalev
Copy link
Author

mertalev commented Nov 1, 2024

Is there anything I need to do about the failing checks? They don't seem related to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant