Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor regexes and mappings class and constants. #3789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor regexes and mappings class and constants. #3789

wants to merge 2 commits into from

Conversation

silvio2402
Copy link
Collaborator

This is part 1 of the refactoring related to b/370922064.

  • Refactor the PhoneNumberRegExpsAndMappings class and its helper functions to a new regexpsandmappings.cc file.
  • Move helper functions ExtnDigits and CreateExtnPattern into the PhoneNumberRegExpsAndMappings class.
  • Move helper function PrefixNumberWithCountryCallingCode into the PhoneNumberUtil class.
  • Refactor some common constants to constants.h.
  • Add a test for getting an example number for a type that only exists for a non-geo entity.

@silvio2402 silvio2402 requested a review from tvislavski January 22, 2025 16:27
@silvio2402 silvio2402 requested a review from a team as a code owner January 22, 2025 16:27
@silvio2402 silvio2402 mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvislavski tvislavski Awaiting requested review from tvislavski

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@silvio2402