Support Ubuntu 24.04 out of the box (fixes #261)… while keeping support for more recent Protobuf intact #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effectly makes change "Switch to requires_utf8_validation" (commit de82ae3) conditional with regard to target Protobuf version. Signed-off-by: Sebastian Pipping <[email protected]>
vitalybuka
reviewed
Feb 7, 2025
Effectly reverts these two changes: - 'Replace DebugString with absl::StrCat' (commit 7aed2ed3f4eec486e16c3fb381157ef7a9e172bb) - 'Revert "Switch from StrCat to ShortFormat"' (commit b1736a68e5dfdf95dd36964fa87ecd13050318a1) @vitalybuka confirmed that preprocessor conditionals a la .. > #if PROTOBUF_VERSION >= 4024000 // v3(!).24.0 (commit a6d895988dee9586b1689259f4412d1714ea1e53) for ShortFormat > .. > #else > .. > #endif .. are not necessary here, so a simpler approach was possible. Signed-off-by: Sebastian Pipping <[email protected]>
.. to what GitHub Actions was already doing, effectively. Signed-off-by: Sebastian Pipping <[email protected]>
Signed-off-by: Sebastian Pipping <[email protected]>
Signed-off-by: Sebastian Pipping <[email protected]>
hartwork
force-pushed
the
issue-261-support-ubuntu-24-04-out-of-the-box
branch
from
7fce2e1 to
1e24a32
Compare
This was referenced Feb 7, 2025
Open
vitalybuka
approved these changes
Feb 7, 2025
|
@vitalybuka thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
CC @vitalybuka