-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to run and combine multiple animations simultaneously #4979
base: master
Are you sure you want to change the base?
Conversation
…ly, upgraded to threejs r171, and updated packages to the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is quite a feature, thank you! To make this easier to review and merge, would you be so kind as to split the dependency updates into a separate PR from the animation work? We should be able to quickly merge the updates, but we'll probably need some back-and-forth on the API change. Honestly, it's looking really good though!
packages/render-fidelity-tools/scripts/compare-fidelity-to-last-recorded.sh
Outdated
Show resolved
Hide resolved
…ove appendAnimation method, format codes with clang-format style and fix other requested changes in google#4979 pull request
…of appendAnimation function, improve modelviewer.dev styles and revert dependencies version
Hey there! Here's my rework of that PR message: 👋 Thank you for the helpful feedback! I've made the following changes in this PR:
Let me know if any further adjustments are needed! 🙂 |
Thanks! As this is my last day (see #4975), I'm going to pass this on to one our other maintainers, @diegoteran, who I already talked to about this PR. Looks like a promising feature! |
…improve general performance
…ncy error when installing in postprocessing
Added the ability to run and combine multiple animations simultaneously with
appendAnimation
anddetachAnimation
methods, updated documentation, upgrade to three.js r171 and update all dependencies to latest version