Change INSTANTIATE_TEST_CASE_P to SUITE_P #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIUC this is wanting to make a breaking change the existing C API? I'd suggest you create an issue so that you can explain why you want to make this change and we'll see if anyone chimes in. |
|
Created at #666 |
|
You need to remove the breaking API change to The change to |
fulldecent
force-pushed
the
feat/bump-bazel-c
branch
from
d2203c6 to
4e6018c
Compare
|
Thanks. Squashed, rebased, trimmed. |
drinckes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
INSTANTIATE_TEST_CASE_Pmacro toINSTANTIATE_TEST_SUITE_Pas the C testing framework we use googletest, deprecated the CASE macros in their v1.10.0 release.Original description:
Remove unused param to fix warnings.
Bump bazel testing to fix warnings.
All for C implementation.