-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(guided remediation): document override strategy for Maven remediation #1181
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
+ Coverage 66.66% 68.98% +2.32%
==========================================
Files 200 197 -3
Lines 19005 18800 -205
==========================================
+ Hits 12669 12970 +301
+ Misses 5655 5127 -528
- Partials 681 703 +22 ☔ View full report in Codecov by Sentry. |
#1286 adds support for Maven registry during resolution. As a follow up, this PR updates the documentation for transitive scanning about specifying data source during resolution as well as specifying Maven registry. This PR also corrects the deps.dev API version we are using. We also need to update the documentation in #1181.
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
@michaelkedar shall we review this PR to make sure everything is up to date? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just some minor comments
docs/guided-remediation.md
Outdated
### Maven | ||
|
||
- Dependencies that use properties in their `groupId`/`artifactId` may not be updated correctly. | ||
- Support for profiles is limited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe link to an issue is there is one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't seem to have specific issues for these.
I'm also not 100% on the extent to which we support/don't support these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why I didn't see these. Added the links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! some nits
docs/guided-remediation.md
Outdated
### Maven | ||
|
||
- Dependencies that use properties in their `groupId`/`artifactId` may not be updated correctly. | ||
- Support for profiles is limited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update guided remediation docs page for Maven override strategy.
I've tried to make sure it covers everything - let me know if something's missing.
Currently at rendered at https://michaelkedar.github.io/osv-scanner/experimental/guided-remediation/