Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new VulnerabilityMatcher in guided remediation #1503

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

michaelkedar
Copy link
Member

Following up on #1470

  • Made ResolutionClient use the VulnerabilityMatcher interface (and added helper function to convert deps.dev graphs into inventories)
  • Deleted old VulnerabilityClient
  • Created CachedOSVMatcher to re-implement performance improvements from the original VulnerabilityClient w.r.t. repeated queries.
  • Re-enabled local database capability in osv-scanner fix

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 59.56284% with 74 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (a6d4ec8) to head (5e87da6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../clients/clientimpl/osvmatcher/cachedosvmatcher.go 63.82% 24 Missing and 10 partials ⚠️
scripts/generate_mock_resolution_universe/main.go 0.00% 19 Missing ⚠️
cmd/osv-scanner/fix/main.go 47.82% 12 Missing ⚠️
internal/resolution/client/helper.go 72.00% 7 Missing ⚠️
internal/clients/clientimpl/localmatcher/zip.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
- Coverage   67.06%   66.68%   -0.38%     
==========================================
  Files         200      200              
  Lines       18953    18996      +43     
==========================================
- Hits        12711    12668      -43     
- Misses       5553     5649      +96     
+ Partials      689      679      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/remediation/in_place.go Outdated Show resolved Hide resolved
internal/resolution/client/helper.go Outdated Show resolved Hide resolved
@michaelkedar michaelkedar merged commit fe4eaea into google:main Jan 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants