Add require-corp embedder policy header to service worker #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJakubowicz
force-pushed
the
upstream-cross-origin-embedder-policy
branch
from
0f8d125 to
1268c8a
Compare
|
On further testing this change would be breaking. For example, we often use resources from another origin for demonstrating example images. Any image elements without the
Two proposed options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream a recommended header that enforces CORS.
Documentation for the header: https://html.spec.whatwg.org/multipage/origin.html#coep
DO NOT SUBMIT: In current state this is a breaking change. See comment: #338 (comment)