Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AVX512 support for SkRasterPipeline_opts.h #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pingladd
Copy link

Hi,
The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library.

@skia-codereview-bot
Copy link
Collaborator

This PR (HEAD: 488dccd) has been imported to Gerrit for code review.

Please visit review.skia.org/779576 to see it. Please CC yourself to the Gerrit change.

Note:

  • Skia uses only Gerrit for reviews and submitting code (doc).
  • All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored.
  • The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit.
  • Once the code is ready to be merged, a maintainer will submit the change on Gerrit and skia-codereview-bot will close this PR.
  • Similarly, if a change is abandoned on Gerrit, the corresponding PR will be closed with a note.

@johnstiles-google
Copy link
Contributor

It looks like you have not signed the CLA. Please follow the steps at https://skia.org/docs/dev/contrib/#contribute-code .

@brianosman
Copy link
Contributor

@pingladd I don't know if you've seen, but @johnstiles-google and I have been reviewing the change on Gerrit: https://skia-review.googlesource.com/c/skia/+/779235

The link in the earlier comment here goes to the wrong change - sorry about that. (I think our script for copying GitHub changes to Gerrit made two copies). I'd suggest continuing to work on the change via Gerrit (or consider just uploading a change directly there, rather than on GitHub). See https://skia.org/docs/dev/contrib/ for details.

@pingladd
Copy link
Author

pingladd commented Nov 17, 2023 via email

pingladd added a commit to pingladd/skia that referenced this pull request Dec 12, 2023
Hi,
The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library.

This is an imported pull request from
google#149

GitOrigin-RevId: 3dfeb3b
Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa
pingladd added a commit to pingladd/skia that referenced this pull request Dec 19, 2023
Hi,
The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library.

This is an imported pull request from
google#149

GitOrigin-RevId: 3dfeb3b
Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa

This is an imported pull request from
google#151

GitOrigin-RevId: 02db57e
Change-Id: Ia674977e3c1a083938bbfda1e9d785595896cb88
pingladd added a commit to pingladd/skia that referenced this pull request Dec 19, 2023
Hi,
The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library.

This is an imported pull request from
google#149

GitOrigin-RevId: 3dfeb3b
Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa

This is an imported pull request from
google#151

GitOrigin-RevId: 02db57e
Change-Id: Ia674977e3c1a083938bbfda1e9d785595896cb88
pingladd added a commit to pingladd/skia that referenced this pull request Jan 2, 2024
Hi,
The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library.

This is an imported pull request from
google#149

GitOrigin-RevId: 3dfeb3b
Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa

This is an imported pull request from
google#151

GitOrigin-RevId: 354e9e0
Change-Id: Ia674977e3c1a083938bbfda1e9d785595896cb88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants