This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Request attestation if selected #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpiper
added a commit
that referenced
this pull request
May 30, 2018
Move project to Maven and add Travis CI support (#166) * Initial commit to begin moving the projects to maven Moving the projects to maven will allow easier deployment and build of the project. * Remove Eclipse specific settings and fix pom.xml Finish updating the project to use Maven. * Add travis.yml file for continuous integration * Update travis file for deployment Build u2f-ref-code dependency. Deploy the standard 'noext' version of the app, then replace the 'noext' specific code with the 'crxjs' specific code before deploying the 'crxjs' app. Additionally, remove the deployment page as the latest code will always be live. * Fix issue where origins.json wasn't included in WAR file
cpiper
added a commit
that referenced
this pull request
May 30, 2018
Request attestation if selected (#173) * Initial commit to begin moving the projects to maven Moving the projects to maven will allow easier deployment and build of the project. * Remove Eclipse specific settings and fix pom.xml Finish updating the project to use Maven. * Add travis.yml file for continuous integration * Update travis file for deployment Build u2f-ref-code dependency. Deploy the standard 'noext' version of the app, then replace the 'noext' specific code with the 'crxjs' specific code before deploying the 'crxjs' app. Additionally, remove the deployment page as the latest code will always be live. * Fix issue where origins.json wasn't included in WAR file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://www.chromium.org/security-keys, Chrome is no longer allowing attestations from security keys to be returned by default as part of a U2F request. Attestations can still be requested with an 'attestation' parameter in the Registration Request dictionary.
Adding a checkbox to request attestation during registration requests.