This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Added a "focus-url" property. #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The big problem that I ran into when working with "platinum-push-messaging" on Android (as a "home screen" app) was that clicking the notification would not behave as expected. If the app was closed, then clicking on it opened the app to the desired URL (the value of the message "url" field). However, if the app was already up or open in the background, then clicking on a notification simply refocused the app. This did not trigger the "platinum-push-messaging-click" event, and it was pretty useless; my app needed the URL to change (it used hash routing). The service-worker requirement for a 100% exact URL match, while conservative, does not match with the philosophy of single-page apps. Essentially, if my app is open anywhere, then it should be focused and sent the click event, which my app could then handle appropriately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big problem that I ran into when working with "platinum-push-messaging" on
Android (as a "home screen" app) was that clicking the notification would not
behave as expected.
If the app was closed, then clicking on it opened the app to the desired URL
(the value of the message "url" field). However, if the app was already up
or open in the background, then clicking on a notification simply refocused
the app. This did not trigger the "platinum-push-messaging-click" event, and
it was pretty useless; my app needed the URL to change (it used hash routing).
The service-worker requirement for a 100% exact URL match, while conservative,
does not match with the philosophy of single-page apps. Essentially, if my app
is open anywhere, then it should be focused and sent the click event, which my
app could then handle appropriately.
I've done testing on Chrome 52 for Android and Linux, and everything works as I'd expect it to. If "focus-url" is unspecified (the default), then everything behaves exactly as it did previously.