Fix keyboard scroll

[abitrolly]

Up / Down and PageUp / PageDown don't work to scroll codelab contents.

Reproducing

1. Open https://codelabs.developers.google.com/codelabs/web-assembly-intro/index.html?index=..%2F..%2Findex#0
2. Press Left / Right to ensure pages are flipped
3. Press Up / Down and PageUp / PageDown to see that vertical scroll doesn't work

Expected

Up / Down and PageUp / PageDown scroll step content.

References

• Remove custom handling of up, down, PgUp and PgDown #28
• Keyboard accessibility is broken canonical-web-and-design/tutorials.ubuntu.com#615

Solution

Solution is to re-add keyboard shortcuts from #29 to forward Up / Down keyboard events to specific control, but I have no idea what the action should be. As an alternative, it should be possible to push these keyboard events from parent control to content pane, but again - no idea.

[gitcoinbot]

This issue now has a funding of 0.045 ETH (47.03 USD) attached to it.

• If you would like to work on this issue you can claim it here.
• If you've completed this issue and want to claim the bounty you can do so here
• Questions? Get help on the Gitcoin Slack
• $11423.41 more Funded OSS Work Available at: https://gitcoin.co/explorer

[ToJen]

What is the problem exactly? I pressed the Down and Key Down keys and the page scrolled down/ Vice versa with Up and Page Up keys. If you mean you want these keys to move to the next section i.e. from 1 to 2 then that won't be necessary since the content on each page will extend beyond the browser width depending on screen size.

[KennethAshley]

@ToJen Yea I think when pressing Down and Up @abitrolly wants the content to "step" to the next item. You can still scroll with a mouse or trackpad.

[abitrolly]

@ToJen I am using Firefox 58.0.1 and if I don't explicitly click on the content area, Up/Down keys don't work there. Even after I click content area to make scroll work, after pressing Left/Right to transition to prev/next step, the scrolling behaviour is gone.

[abitrolly]

@KennethAshley I updated description to clarify that I meant vertical scrolling of the step content.

[KennethAshley]

@abitrolly I still think my pull request solves the issue. If you pull down my branch you can test it. Let me know if i interpreted this issue wrong!

[abitrolly]

@KennethAshley you interpreted the issue wrong. Pressing Up and Down should not result in step transition. I am going to try it anyway, since there is a change in event passing.

This is what I had to do on Ubuntu (just notes if anybody wants to repeat the issue locally):

1. sudo apt install npm
2. npm install bower (which says to migrate to yarn - https://bower.io/blog/2017/how-to-migrate-away-from-bower/)
3. sudo npm install -g bower (because I couldn't find how to run bower when installed locally)
4. bower install

Unable to find a suitable version for test-fixture, please choose one by typing one of the numbers below:
    1) test-fixture#^1.0.0 which resolved to 1.1.2 and is required by codelab-components
    2) test-fixture#^3.0.0 which resolved to 3.0.0 and is required by web-component-tester#6.5.0

Prefix the choice with ! to persist it to bower.json

? Answer 1

5. sudo npm install -g polyserve

The issue is there.

6. Fetch branch (didn't work)

$ git fetch https://github.com/KennethAshley/codelab-components fix/keyboard-bindings
remote: Counting objects: 3, done.
remote: Total 3 (delta 2), reused 2 (delta 2), pack-reused 1
Unpacking objects: 100% (3/3), done.
From https://github.com/KennethAshley/codelab-components
 * branch            fix/keyboard-bindings -> FETCH_HEAD

7. Fetch branch with remote (https://stackoverflow.com/questions/14383212/git-pulling-a-branch-from-another-repository)

$ git remote add fork https://github.com/KennethAshley/codelab-components
$ git fetch fork
From https://github.com/KennethAshley/codelab-components
 * [new branch]      ci                    -> fork/ci
 * [new branch]      fix/keyboard-bindings -> fork/fix/keyboard-bindings
 * [new branch]      gh-pages              -> fork/gh-pages
 * [new branch]      master                -> fork/master
$ git checkout fix/keyboard-bindings
Branch fix/keyboard-bindings set up to track remote branch fix/keyboard-bindings from fork.
Switched to a new branch 'fix/keyboard-bindings'
$ polyserve

Now testing. Open http://localhost:8081/components/codelab-components/#google-codelab (8081 is on my machine), click Demo, click on the left gray nav column to switch focus to control, press Down. The slide switches to the next step. This is not the desired behavior for this issue.

[vs77bb]

Hi @KennethAshley are you still interested in this one? cc @abitrolly @owocki

[KennethAshley]

@vs77bb Yea looking into it now

[KennethAshley]

@vs77bb actually you can take this.

[owocki]

@vs77bb is the gitcoin community manager.. i dont think hes gonna take this :P

[KennethAshley]

@owocki @vs77bb ah i see. I was taken off this and ill be quite busy to i'm not sure i'll be able to take it.

[abitrolly]

@owocki there are some bugs here - the comment at #46 (comment) says that @KennethAshley started working on it, but when @KennethAshley stopped the work, the comment is not updated. Issue page says No one has started work on this issue yet., so it is not clear what happened. Is it possible to fetch some issue status changes from Ethereum?

Also - can I somehow change title of the issue on the gitcoin.co side? Right now it is misleading.

[gitcoinbot]

Work for 0.045 ETH (41.94 USD) has been submitted by:

1. @KennethAshley

Submitters, please leave a comment to let the funder (@abitrolly) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

• Learn more on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $9748.63 more Funded OSS Work Available at: https://gitcoin.co/explorer

[KennethAshley]

Uhhhh i didn't submit any work. Not sure with that notification popped up. I was sleeping when this happened.

[owocki]

hey @KennethAshley -- i just ran a script that synced the gitcoin's state of this issue with the smart contract's current state. thats why the comment cropped up. youre saying you didnt submit work at all, or you didnt submit work 7 hours ago?

[KennethAshley]

@owocki I didn't submit work 7 hours ago.

[owocki]

ah it makes sense now.. thanks for letting me know

[abitrolly]

Yea, now https://gitcoin.co/funding/details?url=https://github.com/googlecodelabs/codelab-components/issues/46 contains "Submissions" block with Kenneth. I tried to see when the submission was made, but it is not exposed in interface tooptips, and I couldn't trace the submission transaction in Etherscan.

[owocki]

hai from Gitcoin here 👋

I tried to see when the submission was made, but it is not exposed in interface tooptips, and I couldn't trace the submission transaction in Etherscan.

This is good feedback. I just added a created date field to the bounty submission field so you can now see when the submission was made!

[abitrolly]

@owocki actually, I don't think the date is right. I would consider a proof a link to submission transaction.

[vs77bb]

@abitrolly Catching up on the convo... is this one still open / is @KennethAshley's submission in review?

Also cc @owocki for the feedback above^

[vs77bb]

Bump @abitrolly @owocki @KennethAshley. Apologies if I'm missing something here!

[x1ddos]

I'm afraid we will not be fixing this.
We're working on a complete drop-in replacement using just Custom Elements spec, without Polymer or other frameworks/libs, in https://github.com/googlecodelabs/codelab-elements.

See #49 for more details.
I've also mentioned this issue on googlecodelabs/codelab-elements#17.

[x1ddos]

Closing it as "won't fix". Keep in mind this issue report is not gone. I'm simply moving it to googlecodelabs/codelab-elements#17.

[gitcoinbot]

The funding of 0.045 ETH (28.88 USD @ $641.73/ETH) attached to this issue has been killed by the bounty submitter

• Questions? Get help on the Gitcoin Slack
• $5643.35 more Funded OSS Work Available at: https://gitcoin.co/explorer

[abitrolly]

Thanks everybody for attempting to solve this problem.

@x1ddos let me know if you'd like to get 0.045 ETH as a bonus for moving the issue forward.