Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom handling of up, down, PgUp and PgDown #48

Conversation

KennethAshley
Copy link

Why?

#46

What changed?

  • Added keybindings for up, down, pageup and pagedown.
  • Also added e.preventDefault() so content doesn't jump

Example

Although you cannot tell i am pressing up, down, page up and page down.

pageup

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@x1ddos
Copy link
Contributor

x1ddos commented Apr 17, 2018

Sorry but we can't merge without CLA.

Copy link
Contributor

@x1ddos x1ddos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this actually solves #46 at all.
Let me know if you disagree.

'left': 'selectPrevious',
'right': 'selectNext',
'left up pageup': 'selectPrevious',
'right down pagedown': 'selectNext',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the opposite of #29, which was done for a specific and clear reason.
Not sure what re-adding it here solves vertical scrolling issue described in #46.

@x1ddos
Copy link
Contributor

x1ddos commented Apr 17, 2018

Closing due to unclear intent in the change, missing CLA and no activity.

@x1ddos x1ddos closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants