-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VEP runner to use Life Sciences API beta & VEP 104 #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@moschetti Please note this merge was blocked and it is much needed. |
Also it seems the ftp path, reverted to small vep instead of caps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moschetti There does not exist a mouse_mm9
, though there is a mus_musculus
:
[pgrosu]$ gsutil ls gs://cloud-lifesciences/vep/
gs://cloud-lifesciences/vep/
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh37_104.tar.gz
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh37_91.tar.gz
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh38_104.tar.gz
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh38_91.tar.gz
gs://cloud-lifesciences/vep/vep_cache_mus_musculus_GRCm39_104.tar.gz
[pgrosu]$
@hnawar we're working on as couple other fixes as well right now with a plan to cut a new release shortly with multiple fixes so this is on hold to merge until then. |
these are being updated because this branch updates to use VEP 104 from 91 so there are different annotations included
Moschetti/vepversioning
--location
flagI will re-run tests after the variant-annotation updates and the new container push.
Fixes #650, #655, #665