Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VEP runner to use Life Sciences API beta & VEP 104 #698

Merged
merged 57 commits into from
Feb 8, 2022
Merged

Update VEP runner to use Life Sciences API beta & VEP 104 #698

merged 57 commits into from
Feb 8, 2022

Conversation

moschetti
Copy link
Member

@moschetti moschetti commented Jun 5, 2021

I will re-run tests after the variant-annotation updates and the new container push.

Fixes #650, #655, #665

@moschetti moschetti requested a review from samanvp June 5, 2021 00:03
Copy link
Collaborator

@lawrenae lawrenae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnawar
Copy link

hnawar commented Nov 7, 2021

@moschetti Please note this merge was blocked and it is much needed.
Thanks

@hnawar
Copy link

hnawar commented Nov 7, 2021

Also it seems the ftp path, reverted to small vep instead of caps
ftp://ftp.ensembl.org/pub/release-104/variation/vep/homo_sapiens_vep_104_GRCh38.tar.gz

Copy link

@pgrosu pgrosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moschetti There does not exist a mouse_mm9, though there is a mus_musculus:

[pgrosu]$ gsutil ls gs://cloud-lifesciences/vep/
gs://cloud-lifesciences/vep/
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh37_104.tar.gz
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh37_91.tar.gz
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh38_104.tar.gz
gs://cloud-lifesciences/vep/vep_cache_homo_sapiens_GRCh38_91.tar.gz
gs://cloud-lifesciences/vep/vep_cache_mus_musculus_GRCm39_104.tar.gz
[pgrosu]$

@moschetti
Copy link
Member Author

@hnawar we're working on as couple other fixes as well right now with a plan to cut a new release shortly with multiple fixes so this is on hold to merge until then.

@lawrenae lawrenae linked an issue Feb 3, 2022 that may be closed by this pull request
@lawrenae lawrenae merged commit 825eb80 into googlegenomics:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the VEP release used for annotations Update vep_runner.py to use Life Sciences v2beta API
5 participants