Introduce RetriesDefaultWaitTime #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No retries will be performed in case of that the 429 response does not include a "Retry-After" header. The PR adds a new default wait time, which can be set to perform retries
|
I don't think that we should ship generic retry functions in Gophercloud. A retry mechanism can be implemented on the consumer side, possibly by using any of the specialised libraries on the Net. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No retries will be performed in case of a 429 response does not include a
Retry-Afterheader.This PR adds a new default wait time, which can be set to perform retries.