Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID Leak #578

Open
jsenning opened this issue Jun 8, 2021 · 5 comments
Open

Fix ID Leak #578

jsenning opened this issue Jun 8, 2021 · 5 comments
Labels

Comments

@jsenning
Copy link
Contributor

jsenning commented Jun 8, 2021

All users seem to be able to access ID numbers using the api/accounts/username/ and api/accounts/email/ routes.

@EjPlatzer says that this has been on ongoing project but IDs are used in multiple places as keys. We've been shifting to using the ADusername but this process is ongoing

@jsenning jsenning added 2 Points To measure progress Privacy labels Jun 8, 2021
@EjPlatzer
Copy link
Contributor

I don't think this is true. Currently, only FacStaff, Police, and group admins are authorized to use these routes.

@jason-whitehouse
Copy link
Contributor

Facstaff and police are essentially the same group? I don't think we have any students with police flagged access correct? Although I suppose it's good to keep it in the criteria if the need should ever arise.

@jsenning jsenning removed the 2 Points To measure progress label Jun 14, 2021
@bennettforkner
Copy link
Contributor

ScheduleControl also returns a Gordon ID number when you request for a specific username.

@bennettforkner
Copy link
Contributor

I have removed id numbers from memberships, requests, and admin.

ScheduleControl and Profiles, possibly among others, still include id numbers.

@bennettforkner bennettforkner removed their assignment Nov 22, 2022
@russtuck
Copy link
Member

russtuck commented Jun 7, 2024

Is this done? Needs checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants