Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ID Numbers from Membership & Request Endpoints #720

Merged
merged 55 commits into from
Nov 17, 2022
Merged

Remove ID Numbers from Membership & Request Endpoints #720

merged 55 commits into from
Nov 17, 2022

Conversation

bennettforkner
Copy link
Contributor

@bennettforkner bennettforkner commented Oct 6, 2022 •
edited
Loading

See UI#1533

Addresses parts of #578

bennettforkner
bennettforkner commented Oct 6, 2022
View reviewed changes
Copy link
Contributor Author

@bennettforkner bennettforkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting for my own notes & to do list.

Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Gordon360/Controllers/EmailsController.cs Outdated Show resolved Hide resolved
Gordon360/Controllers/MembershipsController.cs Outdated Show resolved Hide resolved
Gordon360/Controllers/MembershipsController.cs Outdated Show resolved Hide resolved
Gordon360/Services/AccountService.cs Show resolved Hide resolved
Gordon360/Services/MembershipService.cs Outdated Show resolved Hide resolved
Gordon360/Services/MembershipService.cs Outdated Show resolved Hide resolved
Gordon360/Services/MembershipService.cs Outdated Show resolved Hide resolved
Gordon360/Services/MembershipRequestService.cs Show resolved Hide resolved
EjPlatzer
EjPlatzer requested changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I had several thoughts, but many of them are just inquiries because I'm missing some context, and some are smaller things.

Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Gordon360/Services/MembershipService.cs Outdated Show resolved Hide resolved
Gordon360/Services/MembershipService.cs Outdated Show resolved Hide resolved
Gordon360/Services/MembershipService.cs Outdated Show resolved Hide resolved
Gordon360/Services/MembershipService.cs Outdated Show resolved Hide resolved
Gordon360/Static Classes/Names.cs Outdated Show resolved Hide resolved
@bennettforkner bennettforkner mentioned this pull request Oct 14, 2022
Merged
@bennettforkner bennettforkner self-assigned this Oct 14, 2022
@bennettforkner bennettforkner added Code Quality Changes to improve development process, cleaning up code and improving abstraction Epic Privacy labels Oct 14, 2022
EjPlatzer
EjPlatzer previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EjPlatzer
EjPlatzer requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I had a couple of questions and comments on small cleanup opportunities.

Gordon360/Controllers/HousingController.cs Outdated Show resolved Hide resolved
Gordon360/Controllers/ProfilesController.cs Outdated Show resolved Hide resolved
Gordon360/Controllers/RequestsController.cs Show resolved Hide resolved
Gordon360/Controllers/RequestsController.cs Outdated Show resolved Hide resolved
Gordon360/Models/ViewModels/MembershipUploadViewModel.cs Show resolved Hide resolved
Gordon360/Services/ServiceInterfaces.cs Outdated Show resolved Hide resolved
EjPlatzer
EjPlatzer previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EjPlatzer
EjPlatzer reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions

Gordon360/Models/CCT/MembershipView.cs Outdated Show resolved Hide resolved
Gordon360/Models/ViewModels/MembershipViewModel.cs Outdated Show resolved Hide resolved
EjPlatzer
EjPlatzer approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bennettforkner bennettforkner merged commit 07fc507 into develop Nov 17, 2022
@bennettforkner bennettforkner deleted the remove_membership_account_by_email branch November 17, 2022 19:05
@EjPlatzer EjPlatzer mentioned this pull request Dec 22, 2022
Merged
@EjPlatzer EjPlatzer mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EjPlatzer EjPlatzer EjPlatzer approved these changes

Assignees

@bennettforkner bennettforkner

Labels
Code Quality Changes to improve development process, cleaning up code and improving abstraction Epic Privacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennettforkner @EjPlatzer