Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ID Numbers from Membership, Request, and Admin Routes #1533

Merged
merged 33 commits into from
Nov 17, 2022
Merged

Remove ID Numbers from Membership, Request, and Admin Routes #1533

merged 33 commits into from
Nov 17, 2022

Conversation

bennettforkner
Copy link
Contributor

@bennettforkner bennettforkner commented Oct 6, 2022 •
edited
Loading

The Membership, Request, and Admin services have been using Gordon ID numbers in the post body when they pass information to the API. Gordon IDs should be protected from view so that other users cannot see them unless absolutely necessary.

This PR along with API #720 remove ID numbers from objects used in the UI and clean up some of the code surrounding the two resources.

EjPlatzer
EjPlatzer reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good so far! Just a couple of very minor things. Looking forward to once this is ready.

.env.development Outdated Show resolved Hide resolved
src/views/InvolvementsAll/index.js Outdated Show resolved Hide resolved
src/services/request.ts Outdated Show resolved Hide resolved
@bennettforkner bennettforkner mentioned this pull request Oct 14, 2022
Merged
@bennettforkner bennettforkner self-assigned this Oct 14, 2022
@bennettforkner bennettforkner added Code Quality Changes to improve development process and infrastructure, cleaned code and improved abstraction Privacy Marks an issue that poses an issue to user privacy Epic labels Oct 14, 2022
@bennettforkner bennettforkner marked this pull request as ready for review October 14, 2022 18:36
EjPlatzer
EjPlatzer requested changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few comments. Some of them are incidental to your changes, so feel free to disregard if you don't think they belong in the scope of this PR.

src/views/Admin/components/AdminList/index.js Outdated Show resolved Hide resolved
src/views/Admin/components/AdminList/index.js Show resolved Hide resolved
...vementProfile/components/Membership/components/MemberList/components/MemberListItem/index.js Outdated Show resolved Hide resolved
...vementProfile/components/Membership/components/MemberList/components/MemberListItem/index.js Outdated Show resolved Hide resolved
...vementProfile/components/Membership/components/MemberList/components/MemberListItem/index.js Show resolved Hide resolved
src/views/InvolvementsAll/index.js Outdated Show resolved Hide resolved
@bennettforkner bennettforkner changed the title Remove ID Numbers from Membership & Request Handling Remove ID Numbers from Membership, Request, and Admin Routes Nov 11, 2022
EjPlatzer
EjPlatzer requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just one bug I noticed this time around.

EjPlatzer
EjPlatzer approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bennettforkner bennettforkner merged commit 9c09030 into develop Nov 17, 2022
@bennettforkner bennettforkner deleted the remove_membership_account_by_email_logic branch November 17, 2022 19:14
@EjPlatzer EjPlatzer mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EjPlatzer EjPlatzer EjPlatzer approved these changes

Assignees

@bennettforkner bennettforkner

Labels
Code Quality Changes to improve development process and infrastructure, cleaned code and improved abstraction Epic Privacy Marks an issue that poses an issue to user privacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennettforkner @EjPlatzer