Release: Fix Clifton Strengths Privacy, Update Memberships and Requests for Security, Fix Attended Events, Update StateYourBusiness #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra slash from image url
Add IsAlumni to Membership Viewmodel
…mail Remove ID Numbers from Membership & Request Endpoints
Fix Attended Events
25Live event IDs were changed, but the join from chapel events was never updated, so the join always returned an empty array. I have updated the join to properly compare event IDs ignoring the concatenated Occurrence ID. I also updated the process to be a Left Join, so that if a Chapel Event ever fails to match a 25Live event, it will still appear in the results (albeit lacking crucial data like name, description, location, and start/end date). This way, the event still appears in the users Attended Events list, even though we can't show them useful data about that event.
Match chapel events to 25Live events properly and robustly
StateYourBusiness previously did only unsafe casts when trying to fetch Arguments to a route. Now, it will instead perform a pattern match to determine if an argument exists as the right type. Also, we were often comparing `username` (and some other strings) with the `==` operator, but this didn't account for different possible casings. Now, the comparison is case-insensitive in all cases.
Update StateYourBusiness arguments and username comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes the following changes: