-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the sourceset recognized by IDE. #51
base: user/sv/gradle-6.0.1-Support
Are you sure you want to change the base?
Make the sourceset recognized by IDE. #51
Conversation
Hi Ron,
|
Hi @sadheeshv, Thank you for checking my PR. For item 1, When I use the plugin with IntelliJ the src/main/gosu and src/test/gosu were not recognized as a sourceset. To overcome it I still need to use the idea plugin just to make those recognized as a source set. For the JavaBasePlugin, it seems to me that we are registering 2 java plugins (i.e. JavaPlugin and JavaBasePlugin). Where in reality we can just use the JavaPlugin itself just register it first in the GosuPlugin. For item 2, That line of code actually made IntelliJ recognized the src/main/gosu and src/test/gosu as a sourceset coming from gradle without using the idea plugin as a support. I tried a lot of different ways to make it work until this one. Can you try the plugin without this PR with IntelliJ and observe the src/main/gosu and src/test/gosu? Then use this PR with IntelliJ - If you have time. |
Recently I learned about this plugin: JetBrains/gradle-idea-ext-plugin This should allow cleaner importation of projects using the "native" Tooling API. |
Hi @DPUkyle, that is the idea plugin that I am talking about on my response to @sadheeshv. For me, why do I need a support plugin (i.e. like the idea plugin). If I can already make my plugin do it, it just showing the completeness of the plugin. Just like what the v0.3.10, it doesn't require any supplementary plugin to be used. I'm just returning its independence. Does the PR breaks any behavior of the plugin? Or any test brokes? |
On my first initial trial to use the original one on this branch with IntelliJ. The gosu sourceset was not recognized but the gradle does. This one makes IntelliJ happy.
I've added some a group name to all the tasks related to this plugin.
Also fixed some unit tests.
Any comments on this to be merged will be greatly appreciated.