Added redis config for port and cache prefix. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stooit
reviewed
Sep 26, 2019
| @@ -145,9 +145,9 @@ public function __toString() { | |||
| if (getenv('LAGOON') && (getenv('ENABLE_REDIS'))) { | |||
| $settings['redis.connection']['interface'] = 'PhpRedis'; | |||
| $settings['redis.connection']['host'] = getenv('REDIS_HOST') ?: 'redis'; | |||
| $settings['redis.connection']['port'] = 6379; | |||
| $settings['redis.connection']['port'] = getenv('REDIS_PORT') ?: 6379; | |||
There was a problem hiding this comment.
Looks good, but Lagoon env var for REDIS_PORT includes more than it should (e.g looks to be REDIS_PORT=tcp://172.30.42.136:6379)
There was a problem hiding this comment.
Good catch, thanks! will update to REDIS_SERVICE_PORT
stooit
approved these changes
Oct 18, 2019
|
Can future changes please start in https://github.com/govCMS/scaffold-tooling which is canonical. Also #97 Will need a following PR once this is committed either way. |
Closed
|
Merged in #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding of the redis port and cache prefix without affecting current behaviour.
Projects will be able to customise the redis HOST, PORT and CACHE_PREFIX if required.