Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Seperate react components into single files #728

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Seperate react components into single files #728

wants to merge 22 commits into from

Conversation

azerella
Copy link
Contributor

@azerella azerella commented Apr 10, 2019 •
edited
Loading

Currently our react components are all bundled into the single file, this PR separates each component into a seperate file.

The seperate files are concatenated together in the lib/react/react.js and then bundled like normal.

NOTES:

@azerella azerella added architecture Issue or pull request related to architecture. enhancement New feature or request. labels Apr 10, 2019
@azerella azerella added this to the Sprint 127 milestone Apr 10, 2019
@azerella azerella changed the base branch from develop to feature/decouple-react-files April 10, 2019 01:05
@azerella azerella mentioned this pull request Apr 10, 2019
Closed
4 tasks
@azerella azerella changed the base branch from feature/decouple-react-files to develop April 10, 2019 01:19
Adam A. Zerella added 21 commits April 12, 2019 11:48
Renamed and moved src/js react files to src/react
59c29e4
Moved jquery components into seperate folders
8ab32da
Corrected import for form tests
ae6adff
Updating template package.json
180258e
Updated compile/precompile directory structures
629911a
Split calllout into seperate files
9e8f869
Refactored component short name
535f942
Seperated react src files
fed44f4
Modified helper.js
d269430
Trailing removing webpack build from main build step, moving to watch
4d00dc6
Updated scripts/helper to get reactDeps from lib
b8da03a
Corrected filenames for react components
c6e70e4
trailing webpack before libs are built :(
c2b46da
Added custom case for 'animate' when required in react
7326f69
Fixed old src/react/react.js file ref in package.json
a83da30
Added basic react proptype jsdoc
e639088
Corrected git rebase diff
c11a01f
Added previously removed name version from main control-input component
d9e81a7
Added back replacement for lib/react/react.js
06720ce
Removed form from package.json tests
a95f0d0
Updating babel transform file
0930a20
@azerella azerella force-pushed the feature/seperate-react-files branch from ee283f1 to b4086e8 Compare April 12, 2019 01:50
@azerella azerella removed this from the Sprint 128🐰🍫 milestone May 1, 2019
@sukhrajghuman sukhrajghuman added the 2.0 Issues related to new versions or updates. label Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sukhrajghuman sukhrajghuman Awaiting requested review from sukhrajghuman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2.0 Issues related to new versions or updates. architecture Issue or pull request related to architecture. enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azerella @sukhrajghuman