Added unit tests (in branch riak_core_3) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test with several slave nodes in a cluster (configured in config/test.exs). To prevent running RiakCore on the master node (harmless, but clutters the logs), invoke with `mix test --no-start` * Fixed a few warnings * Updated riak_core.schema Notes: * Running this project on Elixir 1.6.5 with Erlang 20.3.6. I had to comment out "warnings_as_errors" in `deps/riak_ensemble/rebar.config` and in `deps/riak_core/rebar.config` * This project uses riak_core_ng v3.0.9. Later riak_core_ng commits introduced gen_fsm_compat, which fails with newer Elixir+rebar3 because of "missing erl_vsn" issue: rebar_erl_vsn is a pre-compile hook in rebar.config of gen_fsm_compat and few other projects. Error seems to be caused by Mix not handling rebar3 hooks properly. See elixir-lang/elixir#7733 and Kyorai/riak_core#23 This issue is not specific to erl_vsn: for example, the forked https://github.com/gpad/cuttlefish (see mix.exs) differs from the official version only by rebar.config commenting out: % {provider_hooks, [{post, [{compile, {default, escriptize}}]}]}.
* riak_core_coverage_fsm in riak_core_ng expects additional value from init * added coverage command NoSlides.Service.clear() to remove all keys * Added unit test for all coverage commands
pmenhart
force-pushed
the
riak_core_3
branch
4 times, most recently
from
ab42a9d to
4dbed8a
Compare
* See README for explanation why failing with Erlang/OTP 20
pmenhart
force-pushed
the
riak_core_3
branch
2 times, most recently
from
078abf2 to
8b8a847
Compare
|
Ooh that's cool. Nice work. @pmenhart gotta try this stuff out. |
* This version uses gen_fsm_compat * Fixed rebar3 version 3.6.0 or above is needed to avoid problems compiling riak_ensemble and riak_core. 'mix local.rebar --force' will upgrade rebar3 for your Mix projects
|
The latest commit works with riak_core_ng v3.1.1. Newer rebar3 is needed to avoid problems with gen_fsm_compat "missing erl_vsn". You can upgrade by running |
|
Nice pull request - interesting approach to booting tests +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful for your readers: ExUnit now starts several slave nodes in a cluster (configured in config/test.exs). Ping, key/value, and coverage commands are executed.
I also fixed a bug in CoverageFsm, and added a new coverage command NoSlides.Service.clear() to remove all keys from the store.
A few remarks about running this project on Elixir 1.6.5 with Erlang 20.3.6 are in the Readme.