WIP: Added support for Windows Terminal v0.11.1121.0 or newer #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've determined, that also the structure of the profile list has slightly changed. |
jkrgr0
changed the title
|
@wav3 yes there have been many changes, we are working on a complete refactor for 2.0: If you get this fixed for the existing implementation, it can be maintained for the 1.0 branch, otherwise you can try the 2.0 preview |
|
To be honest, I didn't even notice the other branches.. On the first view it does not seems to be too complex to fix the settings json for the existing implementation. I will dig deeper in this on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 0.11.1121.0 of Windows Terminal the
profiles.jsonhas been renamed tosettings.json(See microsoft/terminal Release notes).To support this change and also to support older releases, I've added a internal function which determines the configuration file path for Windows Terminal.