error handling: include exec_info for better debugging

gpu-mode · Jan 18, 2025 · a279ee2 · a279ee2
1 parent f280070
commit a279ee2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/discord-cluster-manager/bot.py b/src/discord-cluster-manager/bot.py
@@ -79,7 +79,7 @@ async def setup_hook(self):
                 commands = await self.tree.fetch_commands(guild=guild)
                 logger.info(f"Synced commands: {[cmd.name for cmd in commands]}")
         except Exception as e:
-            logger.error(f"Failed to sync commands: {e}")
+            logger.error(f"Failed to sync commands: {e}", exc_info=e)
 
     async def _setup_leaderboards(self):  # noqa: C901
         assert len(self.guilds) == 1, "Bot must be in only one guild"

diff --git a/src/discord-cluster-manager/cogs/leaderboard_cog.py b/src/discord-cluster-manager/cogs/leaderboard_cog.py
@@ -87,7 +87,8 @@ async def async_submit_cog_job(
                     + f"Submission user: {user_id}.\n"
                     + f"Runtime: {score:.9f} seconds.",
                 )
-        except Exception:
+        except Exception as e:
+            logger.error("Error in leaderboard submission", exc_info=e)
             await discord_thread.send(
                 f"Leaderboard submission to '{leaderboard_name}' on {gpu.name} "
                 + f"using {runner_name} runners failed!\n",
@@ -451,7 +452,7 @@ async def _get_submissions_helper(
                 )
 
         except Exception as e:
-            logger.error(str(e))
+            logger.error(str(e), exc_info=e)
             if "'NoneType' object is not subscriptable" in str(e):
                 await send_discord_message(
                     interaction,
@@ -692,7 +693,7 @@ async def leaderboard_create(  # noqa: C901
                 ephemeral=True,
             )
         except Exception as e:
-            logger.error(f"Error in leaderboard creation: {e}")
+            logger.error(f"Error in leaderboard creation: {e}", exc_info=e)
             # Handle any other errors
             await send_discord_message(
                 interaction,

diff --git a/src/discord-cluster-manager/cogs/misc_cog.py b/src/discord-cluster-manager/cogs/misc_cog.py
@@ -19,6 +19,8 @@ async def ping(self, interaction: discord.Interaction):
 
     @app_commands.command(name="resync")
     async def resync(self, interaction: discord.Interaction):
+        logger.info("Resyncing commands")
+
         """Admin command to resync slash commands"""
         if interaction.user.guild_permissions.administrator:
             try:
@@ -27,13 +29,13 @@ async def resync(self, interaction: discord.Interaction):
                 self.bot.tree.clear_commands(guild=interaction.guild)
                 await self.bot.tree.sync(guild=interaction.guild)
                 commands = await self.bot.tree.fetch_commands(guild=interaction.guild)
-                send_discord_message(
+                await send_discord_message(
                     interaction,
                     "Resynced commands:\n" + "\n".join([f"- /{cmd.name}" for cmd in commands]),
                 )
             except Exception as e:
                 logger.error(f"Error in resync command: {str(e)}", exc_info=True)
-                send_discord_message(interaction, f"Error: {str(e)}")
+                await send_discord_message(interaction, f"Error: {str(e)}")
         else:
             await send_discord_message(
                 interaction, "You need administrator permissions to use this command"