Allow arbitrary sets of files to be used in python and cuda runner code #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngc92
force-pushed
the
ngc92/aux-files
branch
from
2366d78 to
a2d81f1
Compare
ngc92
force-pushed
the
ngc92/aux-files
branch
from
a2d81f1 to
48b7a5a
Compare
alexzhang13
reviewed
Jan 15, 2025
There was a problem hiding this comment.
I just had to update the runner to handle the new type of file payload.
to squash, fix arguments for testing runner to squash, fix arguments for testing runner to squash, fix arguments for testing runner for now, fix to train until we fix naming train -> submission
alexzhang13
force-pushed
the
ngc92/aux-files
branch
from
a32eb71 to
d50e0d3
Compare
alexzhang13
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cuda, we specify a set of source files (to compile and link) and header files (just create them), for python a dict of python files and which of these should be executed as the main file.
This will go nicely together with the changes in #130 , and enable us to, e.g., useful utilities as common files. It also enables, on the cuda side, to compile user and tester code separately to prevent any include-based hacks to the tester.