GitHub refactor #137
Merged
GitHub refactor #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngc92
force-pushed
the
github-refactor
branch
3 times, most recently
from
ad600ae to
9e1bdb2
Compare
ngc92
force-pushed
the
github-refactor
branch
from
9e1bdb2 to
ec916c0
Compare
S1ro1
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors the github runner:
Most of the non-discord specific functionality is separated out into a helper, keeping only the actually discord-relevant bits inside the cog.
When testing, I also found that submitting a single script "run github" command was broken, because we unconditionally used to set eval.py, so there is also a drive-by fix here.[went away when rebasing]It also tried to be closer to the modal cog, in that instead of spamming messages, we update one message as we're waiting for the run to finish.
when testing this locally, I get warnings like
not completely sure what this means, I guess it's blocking in a code path that shouldn't be?