Add compose support for android_instrumentation_binary #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,14 +62,16 @@ internal class AndroidInstrumentationBinaryTargetBuilder | |||
| matchedVariant = matchedVariant, | |||
| sourceSetType = SourceSetType.JAVA_KOTLIN, | |||
| ) | |||
| add(androidInstrumentationBinData.toTarget()) | |||
| add(androidInstrumentationBinData.toTarget(project)) | |||
There was a problem hiding this comment.
Can we move this to extractor instead of directly mapping the value here?
Later we can make extractors cacheable and source of truth for migration data.
So androidInstrumentationBinData itself will contain compose field
There was a problem hiding this comment.
Moved it to extractor 🙇🏻♂️
arunkumar9t2
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Following changes in grab/grab-bazel-common/pull/158, this PR will enable compose support for instrumentation binary
Testing
Issues Fixed