Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new plugins {} format in buildscripts and rename flavors to demo and full instead of flavor1 #131

Closed
wants to merge 5 commits into from
Closed

Migrate to new plugins {} format in buildscripts and rename flavors to demo and full instead of flavor1 #131

wants to merge 5 commits into from

Conversation

arunkumar9t2
Copy link
Contributor

@arunkumar9t2 arunkumar9t2 commented Apr 8, 2024 •
edited
Loading

  • Migrate to version catalog for plugins
  • Rename flavor1 and flavor2 to demo and full
  • Move flavor related modules under flavors
  • Add TODO for migrating repositories - it seems when dependencyResolutionManagement is used, we can't read the repositories from project. This needs to be handled separately.
  • Update Gradle to 7.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minkuanlim-grabtaxi minkuanlim-grabtaxi minkuanlim-grabtaxi approved these changes

@vanminh-grabtaxi vanminh-grabtaxi Awaiting requested review from vanminh-grabtaxi vanminh-grabtaxi is a code owner

@arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi Awaiting requested review from arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi is a code owner

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi Awaiting requested review from mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi is a code owner

@stevenchao-grabtaxi stevenchao-grabtaxi Awaiting requested review from stevenchao-grabtaxi stevenchao-grabtaxi is a code owner

@arnav-grabtaxi arnav-grabtaxi Awaiting requested review from arnav-grabtaxi arnav-grabtaxi is a code owner

@adarsh-grabtaxi adarsh-grabtaxi Awaiting requested review from adarsh-grabtaxi adarsh-grabtaxi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunkumar9t2 @minkuanlim-grabtaxi