Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document and test cases for granularity #32

Merged
merged 4 commits into from
Feb 20, 2021
Merged

document and test cases for granularity #32

merged 4 commits into from
Feb 20, 2021

Conversation

vigith
Copy link
Collaborator

@vigith vigith commented Feb 20, 2021

I think the period has some issues if we provide time.Duration v/s ISO8601 (e.g P2W, P3M, PT1H30M, PT0.750S). The query was hanging locally. We can fix that in a separate PR.

@vigith vigith requested a review from jbguerraz February 20, 2021 17:09
jbguerraz
jbguerraz approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@jbguerraz jbguerraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG!

@jbguerraz jbguerraz merged commit 6f260da into master Feb 20, 2021
@vigith vigith deleted the granularity-test branch February 20, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbguerraz jbguerraz jbguerraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vigith @jbguerraz