-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic pipelines - a new foreach
block
#1480
Conversation
I really like the idea of it being component based. I am comparing to terraform's for_each, where you make a "template" resource and have an argument in there which tells it how to expand it into multiple components:
I really like the notion that this is a single component that would be "expanded" based on the evaluation of some list. It could be a built-in component or a previously imported dynamic component. I am not sure how naming of the expanded components would work, but we could figure something out. I'm also not sure if it is possible to reference a dynamically created subcomponent from elsewhere in the config. |
This PR has not had any activity in the past 30 days, so the |
It looks likely that we are going to go with the As a second step, we will need to figure out how to refer to the values that are currently iterated on. Should we actually have a By the way, apparently the Collector already has something like dynamic pipelines. There are observer extensions which you can hook up to a recover creator component. For example, you can have a k8s observer which crates a receiver for each discovered pod. |
dd602e6
to
378cb04
Compare
378cb04
to
cc02bfc
Compare
d8b2547
to
d1591b1
Compare
e8cd817
to
8217e86
Compare
b041704
to
421204a
Compare
💻 Deploy preview deleted. |
foreach
block
* summation1 only sends during run() * summation2 tracks the sum via metrics instead of an export
e16e3e3
to
417bd4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, gave it a first review and will go over it again. Added some comments on tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments but overall fantastic!
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
PR Description
This is a proposal for starting up Alloy pipelines dynamically based on data in transit. For example, if a
discovery
component comes up with 10 targets, Alloy can start 10 sub-pipelines, each dealing with a different target.The PR consists of a a design doc in
docs/design/
and an experimental implementation. The user will have to have the "experimental" cmd flag turned on.Which issue(s) this PR fixes
Fixes #1443