-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix documentation for helm extraPorts #1998
base: main
Are you sure you want to change the base?
Conversation
@jkruke Don't forget to sign the CLA so we can move forward with your PR. The Helm chart tests are not up to date. Please run |
@clayton-cornell The CLA is now signed and I ran the helm tests. |
@grafana/grafana-alloy-maintainers Can one of you take a look at this one? My Helm knowledge isn't strong enough to check/verify these changes. |
@petewall could you check this change to the helm chart please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change for anyone who has deployed alloy with the port
and not hostPort
?
Yes it is, because I easily could change that again. How do you think about it? |
PR Description
Which issue(s) this PR fixes
Fixes #1997
Notes to the Reviewer
PR Checklist