Bump snmp_exporter and modules to v0.28.0 #2830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview available: https://deploy-preview-alloy-2830-zb444pucvq-vp.a.run.app/docs/alloy/latest/ |
clayton-cornell
added
the
type/docs
ptodev
reviewed
Feb 28, 2025
| ifeq ($(USE_CONTAINER),1) | ||
| $(RERUN_IN_CONTAINER) | ||
| else | ||
| @LATEST_SNMP_VERSION=$$(go list -m github.com/prometheus/snmp_exporter | cut -d' ' -f2); \ |
There was a problem hiding this comment.
Can you not get the version using Go templates? It'd be more readable.
| $(RERUN_IN_CONTAINER) | ||
| else | ||
| @LATEST_SNMP_VERSION=$$(go list -m github.com/prometheus/snmp_exporter | cut -d' ' -f2); \ | ||
| sed -i "s|snmp_exporter/[^/]*/snmp.yml|snmp_exporter/$$LATEST_SNMP_VERSION/snmp.yml|" internal/static/integrations/snmp_exporter/common/common.go; \ |
There was a problem hiding this comment.
It'd be nice to have comments above the sed commands to explain what they do. I'm personally not familiar with sed, and I suspect many others are also not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Bump snmp_exporter and modules to v0.28.0 and add make target to update snmp in one
make generate-snmpAlso syncs snmp.yml version to snmp_exporter module used.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist