Add Application to datasource configuration #1107
Conversation
|
|
|
Yes the usage is for tracking the queries in ADX. Currently, we are using multiple ADX datasources with different configurations for the same ADX clusters. This gives us visibility on what "Application" (or datasource for that matter) was used to query ADX. PR updated |
|
Another use case I'm interested in is using Workload Groups by 'Application'. This will give us the ability to limit resources for heavy dashboard queries that are not production critical. https://learn.microsoft.com/en-us/kusto/management/workload-groups?view=microsoft-fabric#use-cases-for-custom-workload-groups |
|
Hi @aangelisc, is there anything I can do on my side do push this? This is a feature we really want |
|
@benmali it looks like you still need to sign the CLA, and I suspect you need to update the PR as Andreas mentioned earlier if you haven't already. For the other use case you mentioned, would you mind putting in an issue feature request? |
benmali
force-pushed
the
feature/datasource_application
branch
2 times, most recently
from
d768a27 to
ec7092e
Compare
benmali
force-pushed
the
feature/datasource_application
branch
from
ec7092e to
c3a0f2e
Compare
|
Hi @taleena , CLA signed. No need for a feature request regarding the workload groups in the meantime. |
|
@benmali I've run the CI (unfortunately we have to approve builds from external contributors, which is why it was pending) but it is currently failing the lint step, could you check the output and resolve the errors? |
|
@adamyeats Should be fixed now. Please rerun |
|
@adamyeats I see that I missed one function def. Hope it is fixed now |
|
@adamyeats I see that the CI is failing beacause of missing I can see here https://launchpad.net/ubuntu/jammy/+package/libasound2 that this is an ubuntu 22.04 package, while the runner you are using is ubuntu-latest runner image, which is ubuntu 24.04 as described here: https://github.com/actions/runner-images I'm guessing changing the runner to ubuntu-22.04 in the failing steps will solve this. Also, discussed in this issue. |
…grafana#1148) * Bump github.com/grafana/grafana-plugin-sdk-go from 0.260.1 to 0.263.0 Bumps [github.com/grafana/grafana-plugin-sdk-go](https://github.com/grafana/grafana-plugin-sdk-go) from 0.260.1 to 0.263.0. - [Release notes](https://github.com/grafana/grafana-plugin-sdk-go/releases) - [Commits](grafana/grafana-plugin-sdk-go@v0.260.1...v0.263.0) --- updated-dependencies: - dependency-name: github.com/grafana/grafana-plugin-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * go mod tidy --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Yeats <[email protected]>
…rafana#1145) Bumps [github.com/grafana/grafana-azure-sdk-go/v2](https://github.com/grafana/grafana-azure-sdk-go) from 2.1.3 to 2.1.5. - [Release notes](https://github.com/grafana/grafana-azure-sdk-go/releases) - [Changelog](https://github.com/grafana/grafana-azure-sdk-go/blob/main/CHANGELOG.md) - [Commits](grafana/grafana-azure-sdk-go@v2.1.3...v2.1.5) --- updated-dependencies: - dependency-name: github.com/grafana/grafana-azure-sdk-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 50.6.0 to 50.6.2. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v50.6.0...v50.6.2) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.0.11 to 3.2.3. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.0.11...3.2.3) --- updated-dependencies: - dependency-name: dompurify dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [cypress](https://github.com/cypress-io/cypress) from 13.16.0 to 14.0.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v13.16.0...v14.0.0) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [cspell](https://github.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell) from 8.16.1 to 8.17.2. - [Release notes](https://github.com/streetsidesoftware/cspell/releases) - [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/packages/cspell/CHANGELOG.md) - [Commits](https://github.com/streetsidesoftware/cspell/commits/v8.17.2/packages/cspell) --- updated-dependencies: - dependency-name: cspell dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 9.1.0 to 10.0.1. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v9.1.0...v10.0.1) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) from 5.3.10 to 5.3.11. - [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases) - [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/terser-webpack-plugin@v5.3.10...v5.3.11) --- updated-dependencies: - dependency-name: terser-webpack-plugin dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.37.2 to 7.37.4. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.37.2...v7.37.4) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@benmali Apologies for the difficulties here! I think one more rebase from |
|
@adamyeats Done |
benmali
dismissed
adamyeats’s stale review
The merge-base changed after approval.
|
Note for @grafana/partner-datasources: parts of the pipeline are broken here at the moment. I'm merging this in anyway for now so we can unblock this. |
adamyeats
dismissed
aangelisc’s stale review
Stale, feedback has been resolved
benmali
dismissed
adamyeats’s stale review
The merge-base changed after approval.
Added 'Application' option to Datasource config instead of hardcoded 'Grafana-ADX'