Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ebpf objects on CI #1639

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Build ebpf objects on CI #1639

merged 6 commits into from
Feb 12, 2025

Conversation

rafaelroquetto
Copy link
Contributor

@rafaelroquetto rafaelroquetto commented Feb 11, 2025

This PR introduces the building of the eBPF files by the CI. This ensures that:

  • no user provided file will be merged into the repo -> those will be stomped
  • integrity and consistency across Beyla builds, since we will always be using the same toolchain

The new workflow ensures that tests are only run after it has verified that no ebpf files need to be built. This can happen either when there are no changes impacting ebpf files or after the CI has built the ebpf file itself. A new commit will be automatically added to the head of the PR branch authored by the github actions bot. See it in action at the bottom of this PR.

Important notes

  • your branch may end up with a new commit image
  • In order to retrigger a failed workflow, you need to wait for the others to complete, then the retrigger button will appear.

Closes #1243

@rafaelroquetto rafaelroquetto force-pushed the builder_ebpf_test branch 2 times, most recently from 966ad03 to 3920843 Compare February 11, 2025 21:55
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.07%. Comparing base (0c41a85) to head (a72313b).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (0c41a85) and HEAD (a72313b). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (0c41a85) HEAD (a72313b)
oats-test 1 0
k8s-integration-test 1 0
integration-test 10 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1639       +/-   ##
===========================================
- Coverage   71.18%   47.07%   -24.12%     
===========================================
  Files         197      197               
  Lines       19909    19909               
===========================================
- Hits        14173     9372     -4801     
- Misses       5054    10025     +4971     
+ Partials      682      512      -170     
Flag Coverage Δ
integration-test ?
k8s-integration-test ?
oats-test ?
unittests 47.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaelroquetto rafaelroquetto force-pushed the builder_ebpf_test branch 26 times, most recently from baed229 to 5063dcd Compare February 12, 2025 01:32
@rafaelroquetto rafaelroquetto changed the title WIP: Test workflow_run Build ebpf objects on CI Feb 12, 2025
@rafaelroquetto rafaelroquetto force-pushed the builder_ebpf_test branch 2 times, most recently from f77d58d to 3dd897e Compare February 12, 2025 16:27
@rafaelroquetto rafaelroquetto marked this pull request as ready for review February 12, 2025 16:36
@rafaelroquetto rafaelroquetto requested a review from a team as a code owner February 12, 2025 16:36
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafaelroquetto rafaelroquetto merged commit 4639d0e into main Feb 12, 2025
14 checks passed
@rafaelroquetto rafaelroquetto deleted the builder_ebpf_test branch February 12, 2025 19:38
rafaelroquetto added a commit that referenced this pull request Feb 13, 2025
rafaelroquetto added a commit that referenced this pull request Feb 13, 2025
* Revert "Remove codecov from VM tests (#1647)"

This reverts commit fd2b06e.

* Revert "Remove stray debug message (#1648)"

This reverts commit 41f2551.

* Revert "Build ebpf objects on CI (#1639)"

This reverts commit 4639d0e.

* Update eBPF files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build ebpf objects from a standardised container
2 participants