[e2ealerting] Support pass through labels #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for customizing the labels included in the final end_to_end_duration_seconds histogram, allowing multiple probs to be deployed and the latency split by labels forwarded to it from AlertManager.
|
@gotjosh Mind reviewing this? |
|
|
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Tom Hayward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using e2ealerting across our k8s fleet to monitor latency from ingestor to AM and want to be able to break that down by specific tags like cluster name or AZ. We could solve this by generating one rule for each but this becomes harder to manage as our cluster grows automatically. Instead this adds the ability to pass through custom labels from AM to the histogram and improves the timestamp seen logic to track this by the particular facets.
This adds 2 configuration parameters:
receiver.labels-to-track: This controls the label values of a metric that the "seen timestamp" will differentiate. This is useful if you want to track a different timestamp per hostreceiver.labels-to-forward: This controls the labels that will be forwarded from the AM payload to the histogram metric. Useful to break the histogram down by cluster or region.