Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore loop cleanup and fix omitted spec #1883

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Chore loop cleanup and fix omitted spec #1883

merged 3 commits into from
Mar 4, 2025

Conversation

Baarsgaard
Copy link
Contributor

@Baarsgaard Baarsgaard commented Mar 3, 2025 •
edited
Loading

.spec is now a required field to prevent below resources from being applied.

apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaContactPoint
metadata:
  name: grafanacontactpoint-sample

Also looked through all for loops and removed all the some := some assignments and // can be removed in go 1.22+ comments

@github-actions github-actions bot added documentation Issues relating to documentation, missing, non-clear etc. bugfix this PR fixes a bug chore labels Mar 3, 2025
@theSuess theSuess added this to the v5.17.0 milestone Mar 3, 2025
@Baarsgaard Baarsgaard force-pushed the chore_loop_cleanup_and_fix_omitted_spec branch from 3864840 to 8142bab Compare March 3, 2025 17:05
@Baarsgaard Baarsgaard marked this pull request as ready for review March 3, 2025 17:28
@theSuess theSuess added this pull request to the merge queue Mar 4, 2025
Merged via the queue into grafana:master with commit 6804047 Mar 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSuess theSuess theSuess approved these changes

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

@weisdd weisdd Awaiting requested review from weisdd weisdd is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
bugfix this PR fixes a bug chore documentation Issues relating to documentation, missing, non-clear etc.
Projects
None yet
Milestone
v5.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Baarsgaard @theSuess