NSQ mixin #719
Merged
NSQ mixin #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add topic metrics
repeat topics panels
- set of two dashboards - nsqgrafonnet timeseries panel used
v-zhuravlev
force-pushed
the
vzhuravlev/nsq-mixin
branch
from
af24785 to
9dd545d
Compare
v-zhuravlev
force-pushed
the
vzhuravlev/nsq-mixin
branch
from
685bbb9 to
0875135
Compare
v-zhuravlev
force-pushed
the
vzhuravlev/nsq-mixin
branch
from
a3ece3b to
e503dc8
Compare
rgeyer
approved these changes
Jan 14, 2022
| local prometheus = grafana.prometheus; | ||
|
|
||
| { | ||
| new(title, description=null):: |
There was a problem hiding this comment.
This is great, I'll likely use it in some of my future mixins.
Do we anticipate building more of these for other newer visualizations?
Do we think that it makes sense to offer this upstream to grafonnet, or as a separate extension library?
There was a problem hiding this comment.
Even though there concerns about grafonnet lib(grafana/grafonnet-lib#332), I think we should use some time to update grafonnet upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces NSQ mixin.
NSQ exposes metrics via statsd, so Grafana agent/statsd_exporter required so get metrics into Prometheus.
This NSQ mixin interesting features:
Set of two dashboards:
NSQ Topics - view metrics grouped by topics and channels
NSQ Instances - view metrics grouped by nsqd instances
Dashboard links to quickly jump from one dashboard(view) to another.
Data links to contextually jump from instance view to topics view and vice versa
Alerts for topics and channel depth.
In order to test this mixin with live data, please use sample app in dev environment.