Merge pull request #54 from grafana/async/element-handle-null

Return Promise<string | null> from `elementHandle.textContent()`
grafana · Jun 18, 2024 · ec7918a · ec7918a
2 parents 134104e + a9fede2
commit ec7918a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/types/k6/experimental/browser.d.ts b/types/k6/experimental/browser.d.ts
@@ -1371,7 +1371,7 @@ export interface ElementHandle extends JSHandle {
      * Returns the `node.textContent`.
      * @returns The text content of the element.
      */
-    textContent(): Promise<string>;
+    textContent(): Promise<string | null>;
 
     /**
      * Scrolls element into view, focuses element and types text.

diff --git a/types/k6/test/browser.ts b/types/k6/test/browser.ts
@@ -1561,7 +1561,7 @@ async function test() {
     // $ExpectType Promise<void>
     elementHandle.tap({ trial: true });
 
-    // $ExpectType Promise<string>
+    // $ExpectType Promise<string | null>
     elementHandle.textContent();
 
     // @ts-expect-error