-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jslib-aws links & general improvements to that specific section #1453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleiade thanks for all these improvements!! I went through a few of the changes locally and tested out the links, and everything looks good.
I left a few comments that are all the same, we have a general rule for the Grafana docs that the title
front matter property should match the h1 heading for the page. Do you want me to go through and fix those in the PR for you? I think once that's fixed we can merge it.
docs/sources/next/javascript-api/jslib/aws/EventBridgeClient/putEvents.md
Show resolved
Hide resolved
a13d3ed
to
f1931d1
Compare
Thanks a lot for the review @heitortsergent I've applied the change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oleiade! I did a quick scan and found just one h1 title that still had a ()
, everything else looks good! Feel free to merge when you're ready .
docs/sources/v0.47.x/javascript-api/jslib/aws/KMSClient/listKeys.md
Outdated
Show resolved
Hide resolved
…ys.md Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Noice! Thanks a lot for your help @heitortsergent this was a big one!! |
What?
As I was supporting a user with jslib-aws, I noticed that the docs'
jslib/aws
section needed some love. Some links were broken or plainly displayed as markdown.Thus in this PR I:
This is a massive PR, I wouldn't recommend checking every changes individually, but if you could take it for a spin locally and verify that everything looks in order, I'd be grateful 🙇🏻
Checklist
Please fill in this template:
make docs
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.docs/sources/v{most_recent_release}
folder of the documentation.