Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated k6/experimental/tracing #1799

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 6, 2024

What?

Documentation changes around grafana/k6#3855

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@mstoykov mstoykov requested review from a team, inancgumus and ankur22 and removed request for a team November 7, 2024 13:32
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about this project, but I wonder if we should remove the other references.

and so on.

@heitortsergent
Copy link
Collaborator

I think it makes sense to remove the other references as well @inancgumus. We can also include aliases in the jslib utils pages so if people try to access those pages they get redirected to the correct library instead of seeing a 404.

Let me know if you want me to take care of this @mstoykov and I can make the changes in this PR. 🙏

@mstoykov
Copy link
Contributor Author

mstoykov commented Nov 8, 2024

Good catch @inancgumus ... I think I just looked into next and not the other parts of the docs.

@heitortsergent I will be glad if you take care of this 🙇

@oleiade oleiade mentioned this pull request Nov 8, 2024
33 tasks
@heitortsergent heitortsergent requested a review from a team as a code owner November 8, 2024 19:49
@heitortsergent heitortsergent requested review from inancgumus and removed request for a team November 8, 2024 19:49
@heitortsergent
Copy link
Collaborator

Actually, I looked into the other references and I think we can keep them. Since this is being removed in the next version of k6, it makes sense that we just remove them from the next folder. :)

I added aliases from the deleted pages to the http-instrumentation-tempo module, so if anyone had links with latest in it they should be redirected to the correct page and not see a 404.

@oleiade
Copy link
Member

oleiade commented Nov 11, 2024

Merging this to move forward with the release process 🙇‍♂️

@oleiade oleiade merged commit 7f59e97 into main Nov 11, 2024
3 of 4 checks passed
@oleiade oleiade deleted the experimentalTracingRemoval branch November 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants