-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated k6/experimental/tracing
#1799
Conversation
Documentation changes around grafana/k6#3855
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about this project, but I wonder if we should remove the other references.
| [tracing](/javascript-api/k6-experimental/tracing/) | Support for instrumenting HTTP requests with tracing information. | k6-docs/src/data/markdown/translated-guides/en/07 Testing Guides/02 Automated performance testing.md
Line 260 in dde5a2a
To bridge the gap, work out a way to correlate testing results with how you instrument your infrastructure and application code. For instance, connecting or building custom dashboards with test results or using [trace data from your tests](/javascript-api/k6-experimental/tracing/).
and so on.
I think it makes sense to remove the other references as well @inancgumus. We can also include aliases in the jslib utils pages so if people try to access those pages they get redirected to the correct library instead of seeing a 404. Let me know if you want me to take care of this @mstoykov and I can make the changes in this PR. 🙏 |
Good catch @inancgumus ... I think I just looked into @heitortsergent I will be glad if you take care of this 🙇 |
Actually, I looked into the other references and I think we can keep them. Since this is being removed in the next version of k6, it makes sense that we just remove them from the I added aliases from the deleted pages to the |
Merging this to move forward with the release process 🙇♂️ |
What?
Documentation changes around grafana/k6#3855
Checklist
npm start
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.docs/sources/v{most_recent_release}
folder of the documentation.docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)