Replace test-api.k6.io with QuickPizza
#1849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicotdn
commented
Jan 30, 2025
| @@ -35,7 +35,7 @@ The other evaluates whether 95 percent of responses happen within a certain dura | |||
|
|
|||
| {{< code >}} | |||
|
|
|||
| <!-- md-k6:skip --> | |||
There was a problem hiding this comment.
Many in this file need to be run without thresholds because otherwise they will fail due to network latency variations.
There was a problem hiding this comment.
However at least now we are not skipping them.
| @@ -350,3 +352,5 @@ export function handleSummary(data) { | |||
| | Method | Description | | |||
| | :--------------------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------- | | |||
| | [`Client.sendCommand(command, args)`](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/redis/client/client-sendcommand) | Send a command to the Redis server. | | |||
|
|
|||
| <!-- md-k6:skipall --> | |||
There was a problem hiding this comment.
We don't have Redis to test against
federicotdn
requested review from
olegbespalov and
joanlopez
and removed request for
a team,
olegbespalov and
joanlopez
federicotdn
commented
Jan 31, 2025
|
|
||
| expect(response.body).to.have.lengthOf.at.least(500); | ||
| expect(response.body).to.have.lengthOf.at.least(100); |
There was a problem hiding this comment.
I'm not sure what this was trying to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of https://github.com/grafana/k6-cloud/issues/2437.
Replaces all uses of
test-apifor Quickpizza.I will replace the
localhost:3333URLs shortly. After the PR has been reviewed, I'll apply the changes to older k6 versions.Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)